netdev - Re: [PATCH net-next v8 00/19] new ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Feb 2016 16:56:42 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Decotigny <ddecotig@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Ben Hutchings <ben@...adent.org.uk>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-api@...r.kernel.org, linux-mips@...ux-mips.org,
	fcoe-devel@...n-fcoe.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
	Eugenia Emantayev <eugenia@...lanox.co.il>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Ido Shamay <idos@...lanox.com>, Joe Perches <joe@...ches.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Govindarajulu Varadarajan <_govind@....com>,
	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Pravin B Shelar <pshelar@...ira.com>,
	Ed Swierk <eswierk@...portsystems.com>,
	Robert Love <robert.w.love@...el.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Yuval Mintz <Yuval.Mintz@...gic.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	David Decotigny <decot@...glers.com>
Subject: Re: [PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API

On Tue,  9 Feb 2016 16:29:09 -0800
David Decotigny <ddecotig@...il.com> wrote:

> Along the way, I chose to drop in the new structure the 3 ethtool_cmd
> fields marked "deprecated" (transceiver/maxrxpkt/maxtxpkt). They are
> still available for old drivers via the (old) ETHTOOL_GSET/SSET API,
> but are not available to drivers that switch to new API. Of those 3
> fields, ethtool_cmd::transceiver seems to be still actively used by
> several drivers, maybe we should not consider this field deprecated?
> The 2 other fields are basically not used. This transition requires
> some care in the way old and new ethtool talk to the kernel.

Please just fix old drivers. It is perfectly acceptable to break any
out of tree drivers.