netdev - Re: [PATCH net-next] be2net: don't report EVB for older chipsets when SR-IOV is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKvpyk1u=59YZLoX9kTpTFm0=bXdyE-LaZpCobZwmWo+wa5RTg@mail.gmail.com>
Date:	Thu, 11 Feb 2016 10:56:35 +0100
From:	Sathya Perla <sathya.perla@...adcom.com>
To:	Ivan Vecera <ivecera@...hat.com>
Cc:	netdev@...r.kernel.org, Ajit Khaparde <ajit.khaparde@...adcom.com>,
	Padmanabh Ratnakar <padmanabh.ratnakar@...adcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
	Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net-next] be2net: don't report EVB for older chipsets when
 SR-IOV is disabled

On Wed, Feb 10, 2016 at 1:13 PM, Ivan Vecera <ivecera@...hat.com> wrote:
>
> The EVB (virtual bridge) functionality should be disabled on older BE3
> and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting
> is identified by the zero value of total VFs reported by the card.
> The GET_HSW_CONFIG command cannot be used as it is not supported > by these older chipset's FW.
>
..
> ---
>  drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index 9c1fc9d..886fe95 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -4588,6 +4588,8 @@ static int be_ndo_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
>
>         /* BE and Lancer chips support VEB mode only */
>         if (BEx_chip(adapter) || lancer_chip(adapter)) {
> +               if (!pci_sriov_get_totalvfs(adapter->pdev))
> +                       return 0;

Ivan, could you add a one line comment above this check that says "On
BE3/Lancer the VEB is disabled in non-SRIOV profiles". This is to
differentiate this behavior from Skyhawk, where the VEB may be enabled
even in non-SRIOV profiles, like nPAR...

thanks,
-Sathya