netdev - Re: possible patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160210182535.5d46bbca@lwn.net>
Date:	Wed, 10 Feb 2016 18:25:35 -0700
From:	Jonathan Corbet <corbet@....net>
To:	Justin Keller <justincompsci@...il.com>
Cc:	linux-kernel@...r.kernel.org, isdn@...ux-pingi.de,
	netdev@...r.kernel.org
Subject: Re: possible patch

On Wed, 10 Feb 2016 19:49:11 -0500
Justin Keller <justincompsci@...il.com> wrote:

> I am new to submitting patches, so sorry if I am doing it wrong. My idea was
> to change line 147 in drivers/isdn/pcbit/callbacks.c from
> if (cbdata->data.setup.CallingPN == NULL) {
> 
> to
> 
> if (cbdata->data.setup.CallingPN == NULL ||
> sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {

If you want to patch the kernel, the best way to describe what you want to
do is to ... send a patch.

Before you do so, though:

- Please read the available documentation, including SubmittingPatches and
  development-process/*

- Prepare a proper changelog saying *why* you want to make this change.
  You are trying to change the ISDN subsystem, which is pretty static
  these days; what current problem are you running into that makes you
  think this change needs to be applied to the kernel?

Thanks,

jon