netdev - Re: [PATCH] codel: add forgotten inline to functions in header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1455201038.19473.12.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 11 Feb 2016 06:30:38 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Emmanuel Grumbach <emmanuel.grumbach@...el.com>
Cc:	netdev@...r.kernel.org, linux-wireles@...r.kernel.org
Subject: Re: [PATCH] codel: add forgotten inline to functions in header file

On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote:
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
> ---

> -static bool codel_should_drop(const struct sk_buff *skb,
> -			      struct Qdisc *sch,
> -			      struct codel_vars *vars,
> -			      struct codel_params *params,
> -			      struct codel_stats *stats,
> -			      codel_time_t now)
> +static inline bool codel_should_drop(const struct sk_buff *skb,
> +				     struct Qdisc *sch,
> +				     struct codel_vars *vars,
> +				     struct codel_params *params,
> +				     struct codel_stats *stats,
> +				     codel_time_t now)


The lack of inline was done on purpose.

This include file is kind of special, being included by codel and
fq_codel.

Hint : we do not want to force the compiler to inline
codel_should_drop() (or any other function).


See this file as if it was a .c really.