netdev - Re: [net-next v2] bonding: use return instead of goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160211.095724.1673577316117980850.davem@davemloft.net>
Date:	Thu, 11 Feb 2016 09:57:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	zhangshengju@...s.chinamobile.com
Cc:	j.vosburgh@...il.com, netdev@...r.kernel.org
Subject: Re: [net-next v2] bonding: use return instead of goto

From: Zhang Shengju <zhangshengju@...s.chinamobile.com>
Date: Tue,  9 Feb 2016 10:37:46 +0000

> Replace 'goto' with 'return' to remove unnecessary check at label:
> err_undo_flags.
> 
> The reason is that 'err_undo_flags' do two things for the first slave device:
> 1.revert bond mac address if it is set by the slave device.
> 2.revert bond device type if it's not ARPHRD_ETHER.
> 
> It's not necessary for the following three places, they changed neither bond 
> mac address nor type. It's straightforward to return directly.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>

Applied, thanks.