netdev - Re: [PATCH] codel: add forgotten inline to functions in header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA93jw5fY9faaFR8hqxXTMGkg34ONbe0Keo_RC-fyTMW6oFO4Q@mail.gmail.com>
Date:	Thu, 11 Feb 2016 07:46:35 -0800
From:	Dave Taht <dave.taht@...il.com>
To:	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] codel: add forgotten inline to functions in header file

On Thu, Feb 11, 2016 at 7:05 AM, Grumbach, Emmanuel
<emmanuel.grumbach@...el.com> wrote:
> fixing linux-wireless address ...
>
> On 02/11/2016 04:30 PM, Eric Dumazet wrote:
>> On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote:
>>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
>>> ---
>>> -static bool codel_should_drop(const struct sk_buff *skb,
>>> -                          struct Qdisc *sch,
>>> -                          struct codel_vars *vars,
>>> -                          struct codel_params *params,
>>> -                          struct codel_stats *stats,
>>> -                          codel_time_t now)
>>> +static inline bool codel_should_drop(const struct sk_buff *skb,
>>> +                                 struct Qdisc *sch,
>>> +                                 struct codel_vars *vars,
>>> +                                 struct codel_params *params,
>>> +                                 struct codel_stats *stats,
>>> +                                 codel_time_t now)
>>
>> The lack of inline was done on purpose.
>>
>> This include file is kind of special, being included by codel and
>> fq_codel.
>>
>> Hint : we do not want to force the compiler to inline
>> codel_should_drop() (or any other function).
>>
>>
>> See this file as if it was a .c really.
>>
>>
>
> Yeah :) codel_should_drop seemed very long indeed... I wanted to use the
> codel_get_time and associated utils (_before, _after) in iwlwifi.
> They're better than jiffies... So maybe I can just copy that code to
> iwlwifi.

I need to stress that codel as is is not the right thing for wifi,
particularly point to multipoint wifi in highly contended scenarios.
It IS a starting point. We have generally felt that the target needs
to be offset against the actual service opportunities, and the effects
of multicast (with powersave) and other "background" frames, needs to
be smoothed out.

Lacking hardware that can do that, or adaquate sims, has stalled
trying to come up with "the right thing". It looks like you are
putting in place more of the pieces to get there in some tree
somewhere?