netdev - Re: [PATCH net v4] r8169: Bad implementation of netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2016 15:40:07 +0200
From:	Corcodel Marian <asd@...ian1000.go.ro>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net v4] r8169: Bad implementation of netif_carrier_*

On Thu, 2016-02-11 at 08:27 +0200, Corcodel Marian wrote:
>   On probe stage what carrier to stop and rest two situation
>   netif_carrier_* is slow and disturbing autonegociation process.
> 
> Signed-off-by: Corcodel Marian <asd@...ian1000.go.ro>
> ---
>  drivers/net/ethernet/realtek/r8169.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c
> b/drivers/net/ethernet/realtek/r8169.c
> index 1f75478..0f1adfa 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -1675,11 +1675,9 @@ static void __rtl8169_check_link_status(struct
> net_device *dev,
>  		/* This is to cancel a scheduled suspend if there's
> one. */
>  		if (pm)
>  			pm_request_resume(&tp->pci_dev->dev);
> -		netif_carrier_on(dev);
>  		if (net_ratelimit())
>  			netif_info(tp, ifup, dev, "link up\n");
>  	} else {
> -		netif_carrier_off(dev);
>  		netif_info(tp, ifdown, dev, "link down\n");
>  		if (pm)
>  			pm_schedule_suspend(&tp->pci_dev->dev,
> 5000);
> @@ -8441,7 +8439,6 @@ static int rtl_init_one(struct pci_dev *pdev,
> const struct pci_device_id *ent)
>  	if (pci_dev_run_wake(pdev))
>  		pm_runtime_put_noidle(&pdev->dev);
>  
> -	netif_carrier_off(dev);
>  
>  out:
>  	return rc;
How is status with this patch-is accepted or not?
I'm interresed by this patch on order to send another patches wich
depend this.