netdev - RE: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2016 16:53:03 +0000
From:	<Bryan.Whitehead@...rochip.com>
To:	<andrew@...n.ch>, <f.fainelli@...il.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

Florian,
I'm not familiar with the DSA subsystem. Can you refer me to documents about it?

Andrew,
I'm also not familiar with switchdev, or which is better in this case. Can you refer me to documents about it?

At this point my plan is to just get a basic Ethernet controller driver submitted, and later work on switch features.

Regards,
Bryan


-----Original Message-----
From: Andrew Lunn [mailto:andrew@...n.ch] 
Sent: Friday, February 12, 2016 2:21 AM
To: Florian Fainelli
Cc: Bryan Whitehead - C21958; davem@...emloft.net; netdev@...r.kernel.org
Subject: Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

On Thu, Feb 11, 2016 at 06:18:25PM -0800, Florian Fainelli wrote:
> On 11/02/16 10:58, Bryan.Whitehead@...rochip.com wrote:
> > This is the initial submission of an ethernet driver for the 
> > Microchip LAN9352.
> > 
> > The LAN9352 is a 2-Port 10/100 Managed Ethernet Switch with 16-Bit 
> > Non-PCI CPU Interface. The CPU interface includes a basic ethernet 
> > controller interface whose virtual phy is connected internally to a 
> > 3rd port on the embedded switch.
> > 
> > This driver only operates as a simple ethernet controller on the CPU 
> > interface. Since this interface is connected directly to the 
> > embedded switch, the result is that traffic can be sent and received 
> > on both physical ports.
> 
> If this is an integrated switch, have you considered using the DSA 
> subsystem and having this driver just be the Ethernet driver that 
> interfaces to your CPU interface, but does not attempt to configure 
> the switch in any way?

I actually think switchdev might be the better model. Hard to say. The datasheet suggests it could be modelled as a three port switch, so DSA might be appropriate...

      Andrew