netdev - Re: [PATCH] phy: marvell: Fix and unify reg-init behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160215201435.GA12064@archie.tuxnet.lan>
Date:	Mon, 15 Feb 2016 21:14:35 +0100
From:	Clemens Gruber <clemens.gruber@...ruber.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] phy: marvell: Fix and unify reg-init behavior

Hi Florian,

On Mon, Feb 15, 2016 at 10:22:14AM -0800, Florian Fainelli wrote:
> 
> 
> On 15/02/2016 10:19, Florian Fainelli wrote:
> > On 15/02/2016 09:52, Clemens Gruber wrote:
> >> For the Marvell 88E1510, marvell_of_reg_init was called too late (in
> >> m88e1510_config_aneg), which lead to the phy state machine being stuck
> >> at waiting for interrupts, which are off by default on the 88E1510.
> >> This further lead to the ethernet link not coming up at boot.
> >> For some Marvell PHYs, marvell_of_reg_init was not called at all.
> > 
> > You could mention that this became apparent with
> 
> ...
> 113c74d83eef ("net: phy: turn carrier off on phy attach")

Thanks for your comments. I thought it would be better to just leave all
PHYs with special requirements (resets, ..) as they were and only change
the behavior of those who were missing the marvell_of_reg_init calls.
What do you think?

Clemens