netdev - Re: [Intel-wired-lan] [PATCH net-next V2 5/6] e1000: call ndo_stop() instead of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D922F8B9-0F84-45C5-8BD6-6D57ABFAF01D@intel.com>
Date:	Tue, 16 Feb 2016 17:23:05 +0000
From:	"Rustad, Mark D" <mark.d.rustad@...el.com>
To:	Stefan Assmann <sassmann@...nic.de>
CC:	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Brown, Aaron F" <aaron.f.brown@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next V2 5/6] e1000: call
 ndo_stop()	instead of dev_close() when running offline selftest

Aaron F <aaron.f.brown@...el.com> wrote:

>> From: Intel-wired-lan [intel-wired-lan-bounces@...ts.osuosl.org] on  
>> behalf of Stefan Assmann [sassmann@...nic.de]
>> Sent: Wednesday, February 03, 2016 12:20 AM
>> To: intel-wired-lan@...ts.osuosl.org
>> Cc: netdev@...r.kernel.org; davem@...emloft.net; sassmann@...nic.de
>> Subject: [Intel-wired-lan] [PATCH net-next V2 5/6] e1000: call  
>> ndo_stop()       instead of dev_close() when running offline selftest
>>
>> Calling dev_close() causes IFF_UP to be cleared which will remove the
>> interfaces routes and some addresses. That's probably not what the user
>> intended when running the offline selftest. Besides this does not happen
>> if the interface is brought down before the test, so the current
>> behaviour is inconsistent.
>> Instead call the net_device_ops ndo_stop function directly and avoid
>> touching IFF_UP at all.
>>
>> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
>> ---
>>  drivers/net/ethernet/intel/e1000/e1000.h         | 2 ++
>>  drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++--
>>  drivers/net/ethernet/intel/e1000/e1000_main.c    | 8 ++++----
>>  3 files changed, 8 insertions(+), 6 deletions(-)
>
> Checkpatch warns that externs should be avoided in .c files, but they  
> pre-existed and are just being flagged due to the name changing, so...
>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>

Actually, it is the forward declarations in the .c that should be deleted.  
The prototypes should only exist in the .h file.

--
Mark Rustad, Networking Division, Intel Corporation

Download attachment "signature.asc" of type "application/pgp-signature" (842 bytes)