netdev - Re: [PATCH] i40e: remove redundant check on vsi->active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-MU4Mjq6oXfvuO=tadWyXgvovVTgTnmJPf4gHbdHd34Y=xAw@mail.gmail.com>
Date:	Tue, 16 Feb 2016 09:58:27 -0800
From:	Shannon Nelson <shannon.nelson@...el.com>
To:	Colin King <colin.king@...onical.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	Mitch Williams <mitch.a.williams@...el.com>,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i40e: remove redundant check on vsi->active_vlans

On Sat, Feb 13, 2016 at 3:57 PM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> active_vlans is an unsigned long array, hence a null check on this
> array is superfluous and can be removed.
>
> Detected with static analysis by smatch:
>
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c:386
>   i40e_dbg_dump_vsi_seid() warn: this array is probably
>   non-NULL. 'vsi->active_vlans'
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> index 10744a6..aba28be 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> @@ -383,9 +383,8 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)
>                 dev_info(&pf->pdev->dev,
>                          "    netdev: name = %s\n",
>                          vsi->netdev->name);
> -       if (vsi->active_vlans)
> -               dev_info(&pf->pdev->dev,
> -                        "    vlgrp: & = %p\n", vsi->active_vlans);
> +       dev_info(&pf->pdev->dev,
> +                "    vlgrp: & = %p\n", vsi->active_vlans);
>         dev_info(&pf->pdev->dev,
>                  "    netdev_registered = %i, current_netdev_flags = 0x%04x, state = %li flags = 0x%08lx\n",
>                  vsi->netdev_registered,
> --
> 2.7.0
>

Acked-by: Shannon Nelson <shannon.nelson@...el.com>

-- 
==============================================
Mr. Shannon Nelson                        Network Division, Intel Corp.
Shannon.Nelson@...el.com                I don't speak for Intel
                 Parents can't afford to be squeamish