netdev - RE: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 19:41:46 +0000
From:	<Bryan.Whitehead@...rochip.com>
To:	<andrew@...n.ch>
CC:	<f.fainelli@...il.com>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

Andrew,

At this point, I am not tasked with implementing switch features, which would likely take a long time to complete.

If it is too difficult to add switch features later, then they may come as an entirely new driver at that time.

So this driver should only be thought of as operating a single port ethernet controller.

Bryan

-----Original Message-----
From: Andrew Lunn [mailto:andrew@...n.ch] 
Sent: Friday, February 12, 2016 12:18 PM
To: Bryan Whitehead - C21958
Cc: f.fainelli@...il.com; davem@...emloft.net; netdev@...r.kernel.org
Subject: Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

> At this point my plan is to just get a basic Ethernet controller 
> driver submitted, and later work on switch features.

They are not really separable. 

The linux way of dealing with switches is to model each port as a net device. So you should have a lan0 device and a lan1 device for this two port switch. You can put IP addresses on the ports, and use them as separate ports. If you want to bridge the two ports, you create a linux bridge and add the ports to the bridge. Using netdev or DSA, you can then push this configuration down to the hardware, so it performs the actual bridging of packets between ports.

    Andrew