netdev - Re: [net-next PATCH v2 0/8] tc offload for cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160216.145055.1581160555302651949.davem@davemloft.net>
Date:	Tue, 16 Feb 2016 14:50:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	gerlitz.or@...il.com
Cc:	john.fastabend@...il.com, amir@...ai.me, jhs@...atatu.com,
	netdev@...r.kernel.org, jiri@...nulli.us,
	jeffrey.t.kirsher@...el.com
Subject: Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe

From: Or Gerlitz <gerlitz.or@...il.com>
Date: Tue, 16 Feb 2016 21:30:18 +0200

> On Tue, Feb 16, 2016 at 8:00 AM, John Fastabend
> <john.fastabend@...il.com> wrote:
> [...]
> 
>> Specifically this uses a 'big hammer' feature bit
>> to do the offload or not. If the bit is set you get offloaded rules
>> if it is not then rules will not be offloaded. If we can agree on
>> this patch series there are some more patches on my queue we can
>> talk about to make the offload decision per rule using flags similar
>> to how we do l2 mac updates. Additionally the error strategy can
>> be improved to be hard aborting, log and continue, etc. I think
>> these are nice to have improvements but shouldn't block this series.
> 
> John,
> 
> I thought we've got into agreement in netdev that the offloading
> directive would be a tri-state creature (sw, hw and fail the op if
> can't, hw and fallback to sw). Can you please elaborate what do you
> mean by "make the offload decision per rule using flags similar to how
> we do l2 mac updates"

I think John's changes are an intermediate step in a long term
evoluation.

I'm going to apply John's changes as-is, and people can submit relative
changes on top if they want.