lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Feb 2016 20:02:09 +0000 From: "Brown, Aaron F" <aaron.f.brown@...el.com> To: "Rustad, Mark D" <mark.d.rustad@...el.com>, Stefan Assmann <sassmann@...nic.de> CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: RE: [Intel-wired-lan] [PATCH net-next V2 5/6] e1000: call ndo_stop() instead of dev_close() when running offline selftest > From: Rustad, Mark D > Sent: Tuesday, February 16, 2016 9:23 AM > To: Stefan Assmann > Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; davem@...emloft.net; Brown, Aaron F > Subject: Re: [Intel-wired-lan] [PATCH net-next V2 5/6] e1000: call ndo_stop() instead of dev_close() when running offline selftest > > > Checkpatch warns that externs should be avoided in .c files, but they > > pre-existed and are just being flagged due to the name changing, so... > > > > Tested-by: Aaron Brown <aaron.f.brown@...el.com> > > Actually, it is the forward declarations in the .c that should be deleted. > The prototypes should only exist in the .h file. Thanks Mark, I completely missed that the patch added it to both files, too busy reviving older hardware to extend to run the diags against a larger set of parts I guess :")
Powered by blists - more mailing lists