netdev - Re: [net-next PATCH v2 3/8] net: sched: add cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 21:20:49 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	amir@...ai.me, jhs@...atatu.com, davem@...emloft.net,
	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com
Subject: Re: [net-next PATCH v2 3/8] net: sched: add cls_u32 offload hooks
 for netdevs

Tue, Feb 16, 2016 at 07:01:25AM CET, john.fastabend@...il.com wrote:
>This patch allows netdev drivers to consume cls_u32 offloads via
>the ndo_setup_tc ndo op.
>
>This works aligns with how network drivers have been doing qdisc
>offloads for mqprio.
>
>Signed-off-by: John Fastabend <john.r.fastabend@...el.com>

<snip>

>+struct tc_cls_u32_hnode {
>+	u32 handle;
>+	u32 prio;
>+	unsigned int divisor;
>+};
>+
>+enum {

Please name enum and ...

>+	TC_CLSU32_NEW_KNODE,
>+	TC_CLSU32_REPLACE_KNODE,
>+	TC_CLSU32_DELETE_KNODE,
>+	TC_CLSU32_NEW_HNODE,
>+	TC_CLSU32_REPLACE_HNODE,
>+	TC_CLSU32_DELETE_HNODE,
>+};
>+
>+struct tc_cls_u32_offload {
>+	/* knode values */
>+	int command;

... use it here instead of "int"