netdev - Re: [PATCH] net: ti: netcp: restore get/set_pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160216.152421.2271194730635382792.davem@davemloft.net>
Date:	Tue, 16 Feb 2016 15:24:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	grygorii.strashko@...com
Cc:	netdev@...r.kernel.org, arnd@...db.de, fcooper@...com,
	nsekhar@...com, linux-kernel@...r.kernel.org, w-kwok2@...com,
	m-karicheri2@...com, mugunthanvnm@...com
Subject: Re: [PATCH] net: ti: netcp: restore get/set_pad_info()
 functionality

I would like some of the feedback to be taken into consideration and
integrated into this patch.

Part of the reason this regression was introduced was probably because
the purpose of some fields or descriptor semantics was not defined
properly.

Therefore it is absolutely appropriate to properly name and document
these fields as part of the bug fix.

Thank you.