netdev - Re: [PATCH net 1/1] tipc: fix premature addition of node to lookup table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160216.155806.1011700239493236935.davem@davemloft.net>
Date:	Tue, 16 Feb 2016 15:58:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jon.maloy@...csson.com
Cc:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	parthasarathy.bhuvaragan@...csson.com, richard.alpe@...csson.com,
	ying.xue@...driver.com, maloy@...jonn.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net 1/1] tipc: fix premature addition of node to lookup
 table

From: Jon Maloy <jon.maloy@...csson.com>
Date: Wed, 10 Feb 2016 16:14:57 -0500

> In commit 5266698661401a ("tipc: let broadcast packet reception
> use new link receive function") we introduced a new per-node
> broadcast reception link instance. This link is created at the
> moment the node itself is created. Unfortunately, the allocation
> is done after the node instance has already been added to the node
> lookup hash table. This creates a potential race condition, where
> arriving broadcast packets are able to find and access the node
> before it has been fully initialized, and before the above mentioned
> link has been created. The result is occasional crashes in the function
> tipc_bcast_rcv(), which is trying to access the not-yet existing link.
> 
> We fix this by deferring the addition of the node instance until after
> it has been fully initialized in the function tipc_node_create().
> 
> Acked-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied and queued up for -stable, thanks.