netdev - Re: [PATCH net] tcp: do not set rtt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160216.160748.705097911861027818.davem@davemloft.net>
Date:	Tue, 16 Feb 2016 16:07:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net] tcp: do not set rtt_min to 1

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 11 Feb 2016 08:58:18 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> There are some cases where rtt_us derives from deltas of jiffies,
> instead of using usec timestamps.
> 
> Since we want to track minimal rtt, better to assume a delta of 0 jiffie
> might be in fact be very close to 1 jiffie.
> 
> It is kind of sad jiffies_to_usecs(1) calls a function instead of simply
> using a constant.
> 
> Fixes: f672258391b42 ("tcp: track min RTT using windowed min-filter")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Cc: Yuchung Cheng <ycheng@...gle.com>

Applied and queued up for -stable, thanks Eric.