netdev - Re: [net-next PATCH v3 7/8] net: ixgbe: add support for tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C482E0.2080200@gmail.com>
Date:	Wed, 17 Feb 2016 06:25:36 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>
CC:	amir@...ai.me, davem@...emloft.net, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com
Subject: Re: [net-next PATCH v3 7/8] net: ixgbe: add support for tc_u32 offload

On 16-02-17 03:47 AM, Jamal Hadi Salim wrote:
> On 16-02-17 06:42 AM, Jiri Pirko wrote:
>> Wed, Feb 17, 2016 at 12:17:26PM CET, jhs@...atatu.com wrote:
>>> On 16-02-17 12:18 AM, John Fastabend wrote:
> 
>>>
>>> Note: i dont see anything that says "hw". Are you delegating ht 0x800
>>> for h/w only? It is the default ht; so may not be the best choice.
>>
>> That is not implemented in this patchset. hw/sw/hwsw flag will be done
>> in a follow up. So far, the user has only possibility to enable/disable
>> the whole thing by ethtool feature flag.
> 
> [..]
>>> All looks cool but I am just worried about the lack of intent that
>>> something needs to go to hw vs sw. Other worry:
>>> What happens when things fail to install in hw?
>>
>> Silently fail. I believe that this should be handled in the same
>> follow-up I referred to above.
>>
> 
> I can live with the above. John, please consider my comments when
> sending next update.
> So only outstanding issue is you need to fix that NEW with REPLACE
> in patch 3.
> 

Perfect. I'm sending an update for patch 3 now and I'll carry all
your Acks forward thanks for the review Jamal.

> For this patch:
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> 
> cheers,
> jamal
> 
>