netdev - Re: [PATCH net-next v2 0/7] net: unify dst caching for tunnel devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160216.202221.489011866131335381.davem@davemloft.net>
Date:	Tue, 16 Feb 2016 20:22:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pabeni@...hat.com
Cc:	netdev@...r.kernel.org, tgraf@...g.ch, pshelar@...ira.com,
	jbenc@...hat.com, hannes@...essinduktion.org, therbert@...gle.com,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH net-next v2 0/7] net: unify dst caching for tunnel
 devices

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri, 12 Feb 2016 15:43:52 +0100

> This patch series try to unify the dst cache implementations currently
> present in the kernel, namely in ip_tunnel.c and ip6_tunnel.c, introducing a
> new generic implementation, replacing the existing ones, and then using
> the new implementation in other tunnel devices which currently lack it.
> 
> The new dst implementation is compiled, as built-in, only if any device using
> it is enabled.
> 
> Caching the dst for the tunnel remote address gives small, but measurable,
> performance improvement when tunneling over ipv4 (in the 2%-4% range) and
> significant ones when tunneling over ipv6 (roughly 60% when no
> fragmentation/segmentation take place and the tunnel local address
> is not specified).
> 
> v2:
> - move the vxlan dst_cache usage inside the device lookup functions
> - fix usage after free for lwt tunnel moving the dst cache storage inside
>   the dst_metadata,
> - sparse codying style cleanup

Series applied, thanks for doing this work as it is a major improvement.