netdev - Re: [PATCH] drivers: net: cpsw-phy-sel: add dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160217.105104.143723229571677119.davem@davemloft.net>
Date:	Wed, 17 Feb 2016 10:51:04 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	drivshin.allworx@...il.com
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-omap@...r.kernel.org, mugunthanvnm@...com, kwizart@...il.com
Subject: Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for
 unsupported PHY mode

From: "David Rivshin (Allworx)" <drivshin.allworx@...il.com>
Date: Fri, 12 Feb 2016 19:45:36 -0500

> From: David Rivshin <drivshin@...worx.com>
> 
> The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes,
> and silently handled any other values as if MII was specified. In a
> case where the PHY mode was incorrectly specified, or a bug elsewhere,
> there would be no indication of a problem. If MII was the correct mode,
> then this will go unnoticed, otherwise the symptom will be a failure
> to transmit/receive data over the RMII/RGMII link.
> 
> Add a dev_warn() to make this condition obvious and provide a
> breadcrumb to follow.
> 
> Cc: Mugunthan V N <mugunthanvnm@...com>
> Signed-off-by: David Rivshin <drivshin@...worx.com>

Applied to 'net', thanks.  I don't think I'll queue this up for -stable.

Thanks.