netdev - Re: [PATCH net-next v2 1/4] drivers: net: xgene: Add support for Classifier engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160217.120517.1874370262056055172.davem@davemloft.net>
Date:	Wed, 17 Feb 2016 12:05:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	isubramanian@....com
Cc:	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, patches@....com,
	toanle@....com, kdinh@....com, tinamdar@....com
Subject: Re: [PATCH net-next v2 1/4] drivers: net: xgene: Add support for
 Classifier engine

From: Iyappan Subramanian <isubramanian@....com>
Date: Fri, 12 Feb 2016 17:37:02 -0800

> +static void xgene_cle_dn_to_hw(struct xgene_cle_ptree_ewdn *dn,
> +			       u32 *buf, u32 jb)
> +{
> +	u32 i, j = 0;
> +	u32 npp;
> +	struct xgene_cle_ptree_branch *br;

Please order local variables from longest to shortest line (reverse christmas
tree format).

Please address this for your entire submission.

Thank you.