netdev - Re: [PATCH net V1 1/6] net/mlx4_en: Count HW buffer overrun only once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C4B632.8030700@hpe.com>
Date:	Wed, 17 Feb 2016 10:04:34 -0800
From:	Rick Jones <rick.jones2@....com>
To:	Or Gerlitz <ogerlitz@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, Eran Ben Elisha <eranbe@...lanox.com>,
	Yishai Hadas <yishaih@...lanox.com>,
	Amir Vadai <amir@...ai.me>,
	Eugenia Emantayev <eugenia@...lanox.com>
Subject: Re: [PATCH net V1 1/6] net/mlx4_en: Count HW buffer overrun only once

On 02/17/2016 07:24 AM, Or Gerlitz wrote:
> From: Amir Vadai <amir@...ai.me>
>
> RdropOvflw counts overrun of HW buffer, therefore should
> be used for rx_fifo_errors only.
>
> Currently RdropOvflw counter is mistakenly also set into
> rx_missed_errors and rx_over_errors too, which makes the
> device total dropped packets accounting to show wrong results.
>
> Fix that. Use it for rx_fifo_errors only.
>
> Fixes: c27a02cd94d6 ('mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC')
> Signed-off-by: Amir Vadai <amir@...ai.me>
> Signed-off-by: Eugenia Emantayev <eugenia@...lanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>

Reviewed-By: Rick Jones <rick.jones2@....com>

rick