netdev - Re: [PATCH] l2tp: Fix error creating L2TP tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160217.153635.188688180228329961.davem@davemloft.net>
Date:	Wed, 17 Feb 2016 15:36:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mark.tomlinson@...iedtelesis.co.nz
Cc:	netdev@...r.kernel.org, bhong@...cade.com
Subject: Re: [PATCH] l2tp: Fix error creating L2TP tunnels

From: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>
Date: Mon, 15 Feb 2016 16:24:44 +1300

> A previous commit (33f72e6) added notification via netlink for tunnels
> when created/modified/deleted. If the notification returned an error,
> this error was returned from the tunnel function. If there were no
> listeners, the error code ESRCH was returned, even though having no
> listeners is not an error. Other calls to this and other similar
> notification functions either ignore the error code, or filter ESRCH.
> This patch checks for ESRCH and does not flag this as an error.
> 
> Reviewed-by: Hamish Martin <hamish.martin@...iedtelesis.co.nz>
> Signed-off-by: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>

Applied and queued up for -stable, thanks.

But it seems like we might want to filter out that error in a common
location instead of in all of these various spots.