netdev - Re: [PATCH net-next 2/2] phy: marvell: Add support for phy packet generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Feb 2016 23:33:07 +0100
From:	Lino Sanfilippo <LinoSanfilippo@....de>
To:	Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] phy: marvell: Add support for phy packet
 generator

Hi,

On 17.02.2016 21:32, Andrew Lunn wrote:
> +
> +	oldpage = phy_read(phydev, MII_MARVELL_PHY_PAGE);
> +	if (oldpage < 0) {
> +		err = oldpage;
> +		goto out;
> +	}
> +

shouldn't this return immediately? Jump to out label and writing an
error value to the phy does not seem to be correct.

Regards,
Lino