netdev - Re: wlcore: Fix regression in wlcore_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANfgCY0zHtE8Z8knNPsTgnZS-fumdeioU45F1E2KtvpLBckQDg@mail.gmail.com>
Date:	Wed, 17 Feb 2016 16:34:46 +1100
From:	Ross Green <rgkernel@...il.com>
To:	Kalle Valo <kvalo@...eaurora.org>
Cc:	Emil Goode <emil.fsw@...de.io>, Shahar Patury <shaharp@...com>,
	Guy Mishol <guym@...com>,
	Igor Grinberg <grinberg@...pulab.co.il>,
	Uri Mashiach <uri.mashiach@...pulab.co.il>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: wlcore: Fix regression in wlcore_set_partition()

Appreciate your efforts!

Just trying to make sure it does not get lost.
Introduced in rc1, not fixed by ... rc4.

Anyway, I will continue to test, lots of other things still to chase
even in rc4!

Regards,

Ross Green

On Wed, Feb 17, 2016 at 2:24 AM, Kalle Valo <kvalo@...eaurora.org> wrote:
> Ross Green <rgkernel@...il.com> writes:
>
>> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <kvalo@...eaurora.org> wrote:
>>>
>>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>>>> regression causing the wlcore to time out and go into recovery. Reverting the
>>>> changes regarding write of the last partition size brings the module back to
>>>> it's functional state.
>>>>
>>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>>>> Reported-by: Ross Green <rgkernel@...il.com>
>>>> Signed-off-by: Emil Goode <emil.fsw@...de.io>
>>>> [kvalo@...eaurora.org: improved commit log]
>>>
>>> Thanks, applied to wireless-drivers.git.
>>>
>>> Kalle Valo
>>
>> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
>> So the behaviour of firmware reset being called after the access of
>> the last partition timesout.
>>
>> Again tested patch with the new release - 4.5-rc4 and found everything
>> to work as expected again.
>>
>> So Hopefully for rc5 - Please!
>
> It takes some time to get patches into Linus' tree. And being in a
> conference and then getting sick is not really helping. I'm not sure if
> this patch makes to rc5 on time, but I'll try.
>
> --
> Kalle Valo