netdev - Re: [PATCH] net: ti: netcp: restore get/set_pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160218.150801.1433459291829189521.davem@davemloft.net>
Date:	Thu, 18 Feb 2016 15:08:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	m-karicheri2@...com
Cc:	grygorii.strashko@...com, netdev@...r.kernel.org, arnd@...db.de,
	fcooper@...com, nsekhar@...com, linux-kernel@...r.kernel.org,
	w-kwok2@...com, mugunthanvnm@...com
Subject: Re: [PATCH] net: ti: netcp: restore get/set_pad_info()
 functionality

From: Murali Karicheri <m-karicheri2@...com>
Date: Thu, 18 Feb 2016 12:13:10 -0500

> On 02/16/2016 03:24 PM, David Miller wrote:
>> 
>> I would like some of the feedback to be taken into consideration and
>> integrated into this patch.
>> 
>> Part of the reason this regression was introduced was probably because
>> the purpose of some fields or descriptor semantics was not defined
>> properly.
>> 
>> Therefore it is absolutely appropriate to properly name and document
>> these fields as part of the bug fix.
>> 
>> Thank you.
>> 
> David,
> 
> I will take over this from Grygorii as he is out of office. 
> 
> I propose to keep this patch as is and add additional patch to address
> the feedback in the same series (v1). Is that fine with you?

No, I want the code to be clarified along with the bug fix so that
this bug is unlikely to resurface.