netdev - Re: [PATCH net v2] net: dsa: Unregister slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160217.220547.341101768991563084.davem@davemloft.net>
Date:	Wed, 17 Feb 2016 22:05:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, andrew@...n.ch, opendmb@...il.com
Subject: Re: [PATCH net v2] net: dsa: Unregister slave_dev in error path

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 17 Feb 2016 18:43:22 -0800

> With commit 0071f56e46da ("dsa: Register netdev before phy"), we are now trying
> to free a network device that has been previously registered, and in case of
> errors, this will make us hit the BUG_ON(dev->reg_state != NETREG_UNREGISTERED)
> condition.
> 
> Fix this by adding a missing unregister_netdev() before free_netdev().
> 
> Fixes: 0071f56e46da ("dsa: Register netdev before phy")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks Florian.