netdev - Re: [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Feb 2016 14:25:43 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Corcodel Marian <asd@...ian1000.go.ro>
Cc:	netdev@...r.kernel.org
Subject: Re: [net] r8169   Remove duplicate command which set RxVlan and
 RxChksum bits.

On Sun, Jan 31, 2016 at 05:33:08PM +0200, Corcodel Marian wrote:
>  These bits is already set on set geatures stage.
> 
> Signed-off-by: Corcodel Marian <asd@...ian1000.go.ro>
> ---
>  drivers/net/ethernet/realtek/r8169.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 17d5571..a8fb86d 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -8368,7 +8368,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
>  		NETIF_F_HIGHDMA;
>  
> -	tp->cp_cmd |= RxChkSum | RxVlan;
>  

To avoid two consecutive blank lines, which seems excessive here,
you may want to consider removing the blank line before or after the
line of code you are removing.

>  	/*
>  	 * Pretend we are using VLANs; This bypasses a nasty bug where
> -- 
> 2.5.0
>