netdev - Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1455786901.3128.13.camel@intel.com>
Date:	Thu, 18 Feb 2016 01:15:01 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	John Holland <jotihojr@...il.com>,
	David Miller <davem@...emloft.net>
Cc:	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211
 using a device tree blob V4

On Thu, 2016-02-18 at 08:53 +0100, John Holland wrote:
> 
> > On Feb 18, 2016, at 03:29, David Miller <davem@...emloft.net>
> wrote:
> > 
> > From: John Holland <jotihojr@...il.com>
> > Date: Thu, 18 Feb 2016 00:49:17 +0100
> > 
> >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an
> OTP
> >> and has no externel EEPROM interface [1]. The following allows the
> >> driver to pickup the MAC address from a device tree blob when
> >> CONFIG_OF
> >> has been enabled.
> > 
> > Please use the generic eth_platform_get_mac_address(), or
> > alternatively structure your code like the ixgbe and other cases so
> > that SPARC and other OF platforms get this support as well.
> 
> Don't know what you mean. The PCI path in
> eth_platform_get_mac_address() didn't return a devicetree node and I
> can find no instance of of_<function> use in ixgbe.

See commit e1be080f292eba2ef96af999057d1603cd50b473 in my dev-queue
branch.  Sowmini Varadhan provided a patch to
use eth_platform_get_mac_address() instead of the "CONFIG_SPARC"
solution.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)