netdev - Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1455788524.29084.8.camel@redhat.com>
Date:	Thu, 18 Feb 2016 10:42:04 +0100
From:	Paolo Abeni <pabeni@...hat.com>
To:	Jesse Gross <jesse@...nel.org>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Thomas Graf <tgraf@...g.ch>, Jiri Benc <jbenc@...hat.com>,
	Pravin Shelar <pshelar@...ira.com>,
	Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices
 tunneling over ipv6

On Wed, 2016-02-17 at 11:19 -0800, Jesse Gross wrote:
> On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni <pabeni@...hat.com> wrote:
> > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be
> > correctly controlled.") changed the default xmit checksum setting
> > for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not
> > set into external UDP header.
> > This commit changes the rx checksum setting for both lwt vxlan/geneve
> > devices created by openvswitch accordingly, so that lwt over ipv6
> > tunnel pairs are again able to communicate with default values.
> >
> > Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> 
> This is compat code that is being changed here. Based on the previous
> discussion, shouldn't these be made the default for all users?

This change was initially aimed at a smaller scope: use self consistent
default for ovs lwt devices/tunnel terminations.

If there is agreement, I can post a separate patch changing the default
rx checksum setting for plain vxlan and geneve[1] devices tunneling over
ipv6.

Paolo

[1] according to the ietf draft the geneve devices have the same
checksum requirement than vxlan ones