netdev - Re: [PATCH next v3 1/3] ipvlan: scrub skb before routing in L3 mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF2d9jgdBD6+PUKJ6BBB9h6mD7vTmuCNS5hupBSFcXs+K_Vobw@mail.gmail.com>
Date:	Thu, 18 Feb 2016 17:06:23 -0800
From:	Mahesh Bandewar <maheshb@...gle.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Mahesh Bandewar <mahesh@...dewar.net>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH next v3 1/3] ipvlan: scrub skb before routing in L3 mode.

On Thu, Feb 18, 2016 at 4:44 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Thu, Feb 18, 2016 at 4:39 PM, Mahesh Bandewar <maheshb@...gle.com> wrote:
>> [snip]
>>>> -       skb_dst_drop(skb);
>>>> +       skb_scrub_packet(skb, true);
>>>
>>> At least this patch is still same with the previous version. Or am I
>>> missing anything?
>>
>>  xnet param is now set to 'true'.
>
> Oh, I was suggesting to set xnet based on the netns of both ipvlan
> device and physical device, not setting it to be true or false
> unconditionally.
>
Well, thought about that but don't know any use case / user who is
using the ipvlan slave devices in the same ns as master hence decided
to do it this way.

> Something like:
>
> xnet = !netns_eq(dev_net(ipvlan_dev), dev_net(phy_dev));
>
> (not real code, just to show my idea)
>
> Makes any sense?
Sure, it's not hard just did for the said reasons.