netdev - Re: [PATCH] ehea: Drop owner assignment from platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1602190706200.2801@hadrien>
Date:	Fri, 19 Feb 2016 07:06:46 -0500 (EST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Thadeu Lima de Souza Cascardo <cascardo@...ian.org>
cc:	Amitoj Kaur Chawla <amitoj1606@...il.com>,
	cascardo@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ehea: Drop owner assignment from platform_driver



On Fri, 19 Feb 2016, Thadeu Lima de Souza Cascardo wrote:

> On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> > platform_driver does not need to set an owner, it will be populated by
> > the driver core.
> >
> > Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> > ---
> >  drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > index 2a0dc12..d4b022f 100644
> > --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> >  static struct platform_driver ehea_driver = {
> >  	.driver = {
> >  		.name = "ehea",
> > -		.owner = THIS_MODULE,
> >  		.of_match_table = ehea_device_table,
> >  	},
> >  	.probe = ehea_probe_adapter,
> > --
> > 1.9.1
> >
>
> NACK.
>
> ehea does not use platform_driver_register, it uses
> ibmebus_register_driver, which does not set owner.

Thanks for the information.  I will try to update the saemantic patch.

julia