netdev - Re: [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 19 Feb 2016 22:10:14 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ken_kawasaki@...ty.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at
 buf[5]

From: Ken Kawasaki <ken_kawasaki@...ty.com>
Date: Sat, 20 Feb 2016 10:57:06 +0900

> 
> The MAC address of FMV-J182 is stored at buf[5].
> 
> Signed-off-by: Ken Kawasaki <ken_kawasaki@...ty.com>

This is an extremely poor and misleading description of your change.

The original code was accessing the MAC address properly at buf[5] by
starting the iterator 'i' at 5.

The bug is that the indexing of dev->dev_addr[] is incorrect.

Please describe your change more accurately and resubmit this patch.

Thanks.