netdev - Re: [Patch net-next] phy: marvell/micrel: Fix Unpossible condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160219.234209.1817149741397354640.davem@davemloft.net>
Date:	Fri, 19 Feb 2016 23:42:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andrew@...n.ch
Cc:	netdev@...r.kernel.org
Subject: Re: [Patch net-next] phy: marvell/micrel: Fix Unpossible condition

From: Andrew Lunn <andrew@...n.ch>
Date: Sat, 20 Feb 2016 00:35:29 +0100

> commit 2b2427d06426 ("phy: micrel: Add ethtool statistics counters")
> from Dec 30, 2015, leads to the following static checker
> warning:
> 
>         drivers/net/phy/micrel.c:609 kszphy_get_stat()
>         warn: unsigned 'val' is never less than zero.
 ...
> The same problem exists in the Marvell driver. Fix both.
> 
> Fixes: 2b2427d06426 ("phy: micrel: Add ethtool statistics counters")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Reported-by: Julia.Lawall <julia.lawall@...6.fr>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks.