netdev - [PATCH] fmvj18x_cs: fix incorrect indexing of dev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160220191436.346fd0e6c63db659ea6582b9@nifty.com>
Date:	Sat, 20 Feb 2016 19:14:36 +0900
From:	Ken Kawasaki <ken_kawasaki@...ty.com>
To:	netdev@...r.kernel.org
Subject: [PATCH] fmvj18x_cs: fix incorrect indexing of dev->dev_addr[] when
 copying the MAC address


fix incorrect indexing of dev->dev_addr[] when copying the MAC address 
of FMV-J182 at buf[5].

Signed-off-by: Ken Kawasaki <ken_kawasaki@...ty.com>

---

--- linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c.orig	2016-02-19 20:48:40.143852346 +0900
+++ linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c	2016-02-20 10:33:42.137713831 +0900
@@ -469,8 +469,8 @@ static int fmvj18x_config(struct pcmcia_
 		    goto failed;
 	    }
 	    /* Read MACID from CIS */
-	    for (i = 5; i < 11; i++)
-		    dev->dev_addr[i] = buf[i];
+	    for (i = 0; i < 6; i++)
+		    dev->dev_addr[i] = buf[i + 5];
 	    kfree(buf);
 	} else {
 	    if (pcmcia_get_mac_from_cis(link, dev))