netdev - Re: [PATCH 1/1] net-next: do not store needed_headroom in ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+HUmGiV3ziOafun_4-wGovB8k5pmefLGbcUHnpvrFMpLStrFA@mail.gmail.com>
Date:	Sat, 20 Feb 2016 06:55:09 -0800
From:	Francesco Ruggeri <fruggeri@...sta.com>
To:	Francesco Ruggeri <fruggeri@...sta.com>,
	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 1/1] net-next: do not store needed_headroom in ip_tunnel_xmit

On Fri, Feb 19, 2016 at 8:26 PM, Francesco Ruggeri <fruggeri@...sta.com> wrote:
> Misconfigurations can result in local tunnel loops being created.
> __dev_queue_xmit catches packets caught in a loop and drops them,
> but the affected tunnels' needed_headroom can be corrupted in the
> process as it is recursively updated.

The problem with the patch is that it might force a pskb_expand_head
in the most common cases.
On the other hand if a loop is created then it may not be enough to
undo the configuration and the tunnel device itself should be
reinitialized.
Anybody have a better suggestion?

Thanks,
Francesco