netdev - Re: [Patch net] net_sched: fix memory leaks when rmmod tc action modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpXb6ngsdRDo3QpzTis22rdhPwBkv33BPG9WyBffdbTC5A@mail.gmail.com>
Date:	Sat, 20 Feb 2016 16:27:07 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Cc:	Cong Wang <xiyou.wangcong@...il.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net] net_sched: fix memory leaks when rmmod tc action modules

On Fri, Feb 19, 2016 at 4:06 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> We only release the memory of the hashtable itself, not its
> entries inside. We need to do both.
>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Hmm, after a second thought, actually each action should take
a reference to its module, therefore module will not be removed
until all the actions are gone, so no leak here.

The reason why I saw a leak is tcf_hashinfo_destroy() is called
in netns cleanup in the other patch.

So, this patch should be targeted for net-next only. I will resend it
with an updated changelog with the other patch.

Sorry for the confusion.