netdev - Re: [Patch net-next] net_sched: add network namespace support for tc actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWzVoy7eYdf2Yxz2qfoAO5-pDZioACyu7Hws6u7vvP1Yw@mail.gmail.com>
Date:	Sat, 20 Feb 2016 16:46:04 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net-next] net_sched: add network namespace support for tc actions

On Sat, Feb 20, 2016 at 10:36 AM, Daniel Borkmann <daniel@...earbox.net> wrote:
>
> Do you see a way to reduce the code duplication needed across all
> the action modules? I.e. that each of them now needs to register
> a new per netns subsystem, etc. In other words, is there a way the
> action API could be reworked to handle most of this in the tc core
> framework instead?

I definitely agree.

Initially I made a wrapper macro for the per netns API for each tc
action, but it didn't work as I thought, mostly due to the per net ops and
net_id stuffs.

So it is not as easy as it appears, it needs more work. At least the
current code is more readable than using any macro. We can always
refactor the API in the future, and as I mentioned in the changelog that
is in my plan.

Or do you have any quick and easy way to reduce the code?

Thanks.