netdev - Re: [PATCH] netcp: use pointer to fix build fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160222.124651.135368011882918651.davem@davemloft.net>
Date:	Mon, 22 Feb 2016 12:46:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sudipm.mukherjee@...il.com
Cc:	w-kwok2@...com, m-karicheri2@...com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, john.r.fastabend@...el.com
Subject: Re: [PATCH] netcp: use pointer to fix build fail

From: Sudip Mukherjee <sudipm.mukherjee@...il.com>
Date: Mon, 22 Feb 2016 22:55:43 +0530

> While building keystone_defconfig of arm we are getting build failure
> with the error:
 ...
> The callback of ndo_setup_tc should be:
> int (*ndo_setup_tc)(struct net_device *dev, u32 handle, __be16 protocol,
>                     struct tc_to_netdev *tc);
> 
> But we missed marking the last argument as a pointer.
> 
> Fixes: 16e5cc647173 ("net: rework setup_tc ndo op to consume general tc operand")
> CC: John Fastabend <john.r.fastabend@...el.com>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Applied, thanks.