netdev - RE: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D404B55B8@CHN-SV-EXMX02.mchp-main.com>
Date:	Mon, 22 Feb 2016 18:26:21 +0000
From:	<Woojung.Huh@...rochip.com>
To:	<ben@...adent.org.uk>, <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>
Subject: RE: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause
 functions



> -----Original Message-----
> From: Ben Hutchings [mailto:ben@...adent.org.uk]
> Sent: Thursday, February 18, 2016 8:21 PM
> To: Woojung Huh - C21699; davem@...emloft.net
> Cc: netdev@...r.kernel.org
> Subject: Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause
> functions
> 
> On Fri, 2016-02-19 at 00:16 +0000, Woojung.Huh@...rochip.com wrote:
> > > > Ben, thanks for comments.
> > > > How about comment in include/uapi/linux/ethtool.h?
> > > > It says
> > > > ** struct ethtool_pauseparam - Ethernet pause (flow control)
> parameters
> > > > ...
> > > > * If @autoneg is non-zero, the MAC is configured to send and/or
> > > > * receive pause frames according to the result of autonegotiation.
> > > >
> > > > Doesn't this mean get_pauseparam() returns pause settings based on
> > > > Result of autonegotation? Not manual settings of rx_param & tx_param?
> > >
> > > No, get_pauseparam should return the same settings that were passed
> to
> > > the last set_pauseparam.
> > >
> > > Ben.
> >
> > I used drivers/net/ethernet/intel/e1000e driver as reference.
> > It's implementation also returns status updated after autonegotiation.
> > Look into wrong one?
> 
> Unfortunately the API has not always been clearly defined and there are
> lots of bugs (or at least inconsistencies) in drivers.  The comments in
> include/uapi/linux/ethtool.h are supposed to be definitive; if they are
> not clear then please suggest additional or alternative wording.

I will update and repost it.
BTW, do you know which driver is implemented set/get_pauseparam() correctly?

Thanks.