netdev - Re: [Patch net-next] net_sched: add network namespace support for tc actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpVBBE6aah=5YNuBt0G+5Zb7eB-O97FVaYLWLSOjAMrCMQ@mail.gmail.com>
Date:	Mon, 22 Feb 2016 15:51:51 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Daniel Borkmann <daniel@...earbox.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [Patch net-next] net_sched: add network namespace support for tc actions

On Mon, Feb 22, 2016 at 5:42 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> I did a quick look and i am struggling with it. The patch seems largish
> The issue is that we need to do this per kernel module so the code
> churn maybe unavoidable; hinfo stored in act_ops complicates things.
> Having said that:  All the pernet operations in your
> code seem to be generic, other than to accomodate for module specific
> act_ops. Is it possible to make generic pernet operations? This way
> you could do things at tcf_register_action() for all actions.
> The challenge seems to be in the xxx_net_id which appears(sorry didnt
> look closely at the namespace code) to need to be unique id per module
> and per namespace instance - otherwise i would suggest for xxx_net_id

I got some idea to reduce the duplicated code, not all but most.

> to be part of act_ops. Could we not have an #ifdef in the namespace
> core like the netfilter code does and have one level of indirection
> for everything but the namespace 0?

I believe this should be done in a separated patch if really needed.

Thanks.