netdev - Re: [PATCH next v4 0/3] IPvlan misc patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160221.224516.345929630999490010.davem@davemloft.net>
Date:	Sun, 21 Feb 2016 22:45:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mahesh@...dewar.net
Cc:	maheshb@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH next v4 0/3] IPvlan misc patches

From: Mahesh Bandewar <mahesh@...dewar.net>
Date: Sat, 20 Feb 2016 19:31:22 -0800

> From: Mahesh Bandewar <maheshb@...gle.com>
> 
> This is a collection of unrelated patches for IPvlan driver.
> a. crub_skb() changes are added to ensure that the packets hit the
> NF_HOOKS in masters' ns in L3 mode.
> b. u16 change is bug fix while
> c. the third patch is to group tx/rx variables in single cacheline

I applied this series, but this is an extremely poor quality
submission.

You don't capitalize sentences, particularly in the Subject lines
of your patches.

Your descriptions are quite poor.  You say here that patch 'c' is
about grouping things for cache locality but that patch does a lot
of completely unrelated things too.

I really think you put very little effort into the formatting,
descriptions, grouping, and general layout of this patch series.  And
it shows.