netdev - Re: [PATCH] net: jme: fix suspend/resume on JMC260

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Feb 2016 02:11:43 -0300
From:	Diego Viola <diego.viola@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	festevam@...il.com, cooldavid@...ldavid.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	richard.weinberger@...il.com, pavel@....cz, rjw@...ysocki.net
Subject: Re: [PATCH] net: jme: fix suspend/resume on JMC260

On Tue, Feb 23, 2016 at 1:42 AM, David Miller <davem@...emloft.net> wrote:
> From: Diego Viola <diego.viola@...il.com>
> Date: Mon, 22 Feb 2016 22:58:48 -0300
>
>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@...il.com> wrote:
>>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@...il.com> wrote:
>>>> Signed-off-by: Diego Viola <diego.viola@...il.com>
>>>
>>> You should write a commit log.
>>
>> I thought about including the link to my bug report:
>> https://bugzilla.kernel.org/show_bug.cgi?id=112351
>>
>> What else would you suggest I add to the commit message?
>
> The commit message is where you describe the change you are making.
>
> This includes exactly what you are fixing, how you are doing it, and why
> you are doing it that way.
>
> Empty commit log messages are %99.99999 of the time completely
> inappropriate.

David,

I understand and appreciate your advice, thanks.

However, please consider that I'm not a kernel developer, so I don't
understand much or anything about how this driver works internally,
this is why I came here to report about problem in the first place.

All I can tell you for certain is that this change makes my
suspend/resume work and it doesn't hang anymore while resuming from
suspend.

I apologize for the empty commit message and for not being able to
explain things deeper, but Pavel Machek is the person who suggested I
make this change in the code, so maybe he can provide some help?

Diego