netdev - Re: [PATCH v8 4/8] time: Add driver cross timestamp interface for higher precision time synchronization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1602241153260.3670@nanos>
Date:	Wed, 24 Feb 2016 11:54:32 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Christopher S. Hall" <christopher.s.hall@...el.com>
cc:	richardcochran@...il.com, mingo@...hat.com, john.stultz@...aro.org,
	hpa@...or.com, jeffrey.t.kirsher@...el.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
	netdev@...r.kernel.org, kevin.b.stanton@...el.com,
	kevin.j.clarke@...el.com
Subject: Re: [PATCH v8 4/8] time: Add driver cross timestamp interface for
 higher precision time synchronization

On Mon, 22 Feb 2016, Christopher S. Hall wrote:
> +int get_device_system_crosststamp(int (*get_time_fn)
> +				  (ktime_t *device_time,
> +				   struct system_counterval_t *sys_counterval,
> +				   void *ctx),
> +				  void *ctx,
> +				  struct system_device_crosststamp *xtstamp)
> +{
> +	struct timekeeper *tk = &tk_core.timekeeper;
> +	unsigned long seq;
> +	struct system_counterval_t system_counterval;
> +	ktime_t base_raw;
> +	ktime_t base_real;
> +	s64 nsec_raw;
> +	s64 nsec_real;

Single lines for same and desceding length ordered, which makes it simpler to
parse, please.

Other than that: Reviewed-by: Thomas Gleixner <tglx@...utronix.de>