netdev - Re: [PATCH net] net/8021q: Check the correct vlan filter capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160224.114839.300751853393269073.davem@davemloft.net>
Date:	Wed, 24 Feb 2016 11:48:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	saeedm@...lanox.com
Cc:	netdev@...r.kernel.org, galp@...lanox.com, ogerlitz@...lanox.com,
	kaber@...sh.net
Subject: Re: [PATCH net] net/8021q: Check the correct vlan filter capability

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Wed, 24 Feb 2016 18:39:19 +0200

> From: Gal Pressman <galp@...lanox.com>
> 
> Use dev->hw_features in vlan_hw_filter_capable instead of dev->features,
> since dev->features can be turned on/off dynamically.
> 
> Netdev features can be changed dynamically to off after vlan_vid_add
> was called, thus vlan_vid_del will skip ndo_vlan_rx_kill_vid and will
> leave the device driver with un-freed resources.

Are you sure the fix isn't to make vlan_vid_add() check ->features instead
of ->hw_features.

Should we really be trying to add VLAN filters when the user has
turned it off?