netdev - Re: [PATCH net] ipv4: only create late gso-skb if skb is already set up with CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160224.141300.658238403360268304.davem@davemloft.net>
Date:	Wed, 24 Feb 2016 14:13:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, jbenc@...hat.com, wakko@...mx.eu.org
Subject: Re: [PATCH net] ipv4: only create late gso-skb if skb is already
 set up with CHECKSUM_PARTIAL

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Mon, 22 Feb 2016 18:43:25 +0100

> Otherwise we break the contract with GSO to only pass CHECKSUM_PARTIAL
> skbs down. This can easily happen with UDP+IPv4 sockets with the first
> MSG_MORE write smaller than the MTU, second write is a sendfile.
> 
> Returning -EOPNOTSUPP lets the callers fall back into normal sendmsg path,
> were we calculate the checksum manually during copying.
> 
> Commit d749c9cbffd6 ("ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked
> sockets") started to exposes this bug.
> 
> Fixes: d749c9cbffd6 ("ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets")
> Reported-by: Jiri Benc <jbenc@...hat.com>
> Cc: Jiri Benc <jbenc@...hat.com>
> Reported-by: Wakko Warner <wakko@...mx.eu.org>
> Cc: Wakko Warner <wakko@...mx.eu.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied and queued up for -stable, thanks.