netdev - Re: [PATCH net] bpf: fix csum setting for bpf_set_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160224.162400.1248598061435588351.davem@davemloft.net>
Date:	Wed, 24 Feb 2016 16:24:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	alexei.starovoitov@...il.com, tgraf@...g.ch, jesse@...nel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] bpf: fix csum setting for bpf_set_tunnel_key

From: Daniel Borkmann <daniel@...earbox.net>
Date: Tue, 23 Feb 2016 02:05:26 +0100

> The fix in 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be correctly
> controlled.") changed behavior for bpf_set_tunnel_key() when in use with
> IPv6 and thus uncovered a bug that TUNNEL_CSUM needed to be set but wasn't.
> As a result, the stack dropped ingress vxlan IPv6 packets, that have been
> sent via eBPF through collect meta data mode due to checksum now being zero.
> 
> Since after LCO, we enable IPv4 checksum by default, so make that analogous
> and only provide a flag BPF_F_ZERO_CSUM_TX for the user to turn it off in
> IPv4 case.
> 
> Fixes: 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be correctly controlled.")
> Fixes: c6c33454072f ("bpf: support ipv6 for bpf_skb_{set,get}_tunnel_key")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Applied to 'net', thanks Daniel.