netdev - Re: [PATCH net] bnxt_en: Fix zero padding of tx push data.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160223.191320.257252668425313975.davem@davemloft.net>
Date:	Tue, 23 Feb 2016 19:13:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	michael.chan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: Fix zero padding of tx push data.

From: Michael Chan <michael.chan@...adcom.com>
Date: Mon, 22 Feb 2016 02:10:26 -0500

> The arithmetic to zero pad the last 64-bit word in the push buffer is not
> correct.
> 
> 1. It should be pdata + length to get to the end.
> 2. 'pdata' is void pointer and passing it to PTR_ALIGN() will cast the
> aligned pointer to void.  Pass 'end' which is u64 pointer to PTR_ALIGN()
> instead so that the aligned pointer - 1 is the last 64-bit pointer to data.
> 
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Applied, thanks Michael.