netdev - Re: [net-next PATCH 2/4] net: cls_u32: move TC offload feature bit into cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160224061211.GC12134@vergenet.net>
Date:	Wed, 24 Feb 2016 15:12:14 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	jiri@...nulli.us, daniel@...earbox.net, netdev@...r.kernel.org,
	alexei.starovoitov@...il.com, davem@...emloft.net, jhs@...atatu.com
Subject: Re: [net-next PATCH 2/4] net: cls_u32: move TC offload feature bit
 into cls_u32 offload logic

On Tue, Feb 23, 2016 at 11:02:56AM -0800, John Fastabend wrote:
> In the original series drivers would get offload requests for cls_u32
> rules even if the feature bit is disabled. This meant the driver had
> to do a boiler plate check on the feature bit before adding/deleting
> the rule.
> 
> This patch lifts the check into the core code and removes it from the
> driver specific case.
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>